Discussion:
RTP padding bit
Rafael Maia
2010-09-23 09:20:36 UTC
Permalink
Hello,

Is the padding bit 'P' of the RTP being processed anywhere?



I cannot find any place where it is being processed. I have added this in :



PJ_DEF(pj_status_t) pjmedia_rtp_decode_rtp( pjmedia_rtp_session *ses,

const void *pkt, int pkt_len,

const pjmedia_rtp_hdr **hdr,

const void **payload,

unsigned *payloadlen)

{



/*.*/



/* Find and set payload. */

*payload = ((pj_uint8_t*)pkt) + offset;

*payloadlen = pkt_len - offset;



/* the padding bit is set. lets remove a few octetcs from the payload
len */

if ((*hdr)->p) {

*payloadlen -= ((unsigned char* )(*payload))[*payloadlen - 1];

}



return PJ_SUCCESS;

}



Does anyone know where should it be processed when sending RTP packets ?

I was thinks in doing in this method: pjmedia_transport_send_rtp. Before the
(*tp->op->send_rtp) is called.

Any suggestions?



Cheers,

Rafael Maia
Benny Prijono
2010-09-23 10:53:55 UTC
Permalink
Hi,

You may be right. I just added
https://trac.pjsip.org/repos/ticket/1135 to check this further.

Best regards,
 Benny
Post by Rafael Maia
Hello,
Is the padding bit ‘P’ of the RTP being processed anywhere?
PJ_DEF(pj_status_t) pjmedia_rtp_decode_rtp( pjmedia_rtp_session *ses,
                                 const void *pkt, int pkt_len,
                                 const pjmedia_rtp_hdr **hdr,
                                 const void **payload,
                                 unsigned *payloadlen)
{
/*…*/
    /* Find and set payload. */
    *payload = ((pj_uint8_t*)pkt) + offset;
    *payloadlen = pkt_len - offset;
    /* the padding bit is set. lets remove a few octetcs from the payload
len */
    if ((*hdr)->p) {
      *payloadlen -= ((unsigned char* )(*payload))[*payloadlen - 1];
    }
    return PJ_SUCCESS;
}
Does anyone know where should it be processed when sending RTP packets ?
I was thinks in doing in this method: pjmedia_transport_send_rtp. Before the
(*tp->op->send_rtp) is called.
Any suggestions?
Cheers,
Rafael Maia
_______________________________________________
Visit our blog: http://blog.pjsip.org
pjsip mailing list
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
Loading...